Improve unit test coverage

[klaussilveira]

No description provided.

[DannyvdSluijs]

I'm working on the unit test, already at a 52,78% LoC coverage. @klaussilveira, I send you an e-mail regarding the unit test.

[klaussilveira]

Are you working with unit or functional tests? Maybe both? The current test suite in GitList has functional tests for the interface only.

[DannyvdSluijs]

Both unit, as functional. As the majority can be tested with unit, the controllers require functional. I already splitted up the InterfaceTest file, to their proper test files
src/GitList/Controller/MainController.php => test/src/GitList/Controller/MainControllerTest.php
etc.

I just need to work out as that created some duplicate code, to setup the two initial repositories, I'll ponder my brain over that during this week.Hopefully I'll be able to request a pull early next week. Due to some social items in my agenda :-)

[DannyvdSluijs]

Come to think of it, creating a single method for the setting up the repositories would couple the tests together, so I am actually thinking of leaving each separate controller test with its own setupBeforeClass and tearDownAfterClass methods.

Any feedback on this ?

[klaussilveira]

I don't see a problem with this approach. You can also create a fixture file and load it, if the setupBeforeClass() method get's too repetitive.