Forcibly setting $DISPLAY to :0

[ViktorWalter]

On

linux-setup/appconfig/shell/commons.sh_git

Line 5 in ae0e32a

DISPLAY=:0 && xset r rate 350 55 2> /dev/null

the commons.sh is setting the $DISPLAY variable to :0, in order to fix the keyboard repeat rate.
This is problematic, since it breaks ssh X11 Forwarding - when you do e.g. ssh -X user@host, the sshd on host sets $DISPLAY to the appropriate value corresponding to the remote display assigned to the remote session, e.g. localhost:10.0.
Sourcing commons.sh in my .bashrc / .zshrc sets it back to :0, so if I don't manually set it back I can't display remote graphical interfaces.
Instead of manually setting the variable, I would recommend to instead check if $DISPLAY is set before doing xset r rate ....

[matemat13]

Maybe the best solution would be to save the original value of $DISPLAY and then set it back after this line? A good catch, nevertheless!

[ViktorWalter]

Yeah, that's my current workaround:

DISPLAY_STORE=$DISPLAY
source ~/git/linux-setup/appconfig/shell/commons.sh_git
DISPLAY=$DISPLAY_STORE

But apparently we have linux-setup on drones and I'm told some people have already had trouble with ssh -X on them.

[klaxalk]

I am not even sure if the export needs to be there...

[klaxalk]

It seems it works even without it. I will remove it and let's observe if it breaks something.

[ViktorWalter]

This is the best attitude to have 😄.

[klaxalk]

Improvement by reduction :-).

[ViktorWalter]

Let's consider this solved until it breaks something then.