Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obfuscator not using full 256 bits of each byte #59

Closed
DawnStream opened this issue Jun 16, 2022 · 3 comments
Closed

Obfuscator not using full 256 bits of each byte #59

DawnStream opened this issue Jun 16, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@DawnStream
Copy link

When obfuscating the key and when decrypting it, you take the string representation of the sha256 digest. This causes the obfuscator used to be constructed from only [1-10,a-e], and not the full range of the byte values. This guarantee that some bits are never changed (e.g. the MSB, as ascii calues are always less than 127).
I suggest using the original digest value and not "format" it to string value.

@ben-j69
Copy link
Member

ben-j69 commented Jun 17, 2022

Hello @DawnStream ,
thanks for the report, feel free to submit the PR to improve the lib ;)

@ben-j69 ben-j69 added the enhancement New feature or request label Jun 17, 2022
@DawnStream
Copy link
Author

@ben-j69 Just created a PR to fix this. Thanks for this plugin!

@ben-j69
Copy link
Member

ben-j69 commented Jul 5, 2022

Thanks @DawnStream for the PR : #60

@ben-j69 ben-j69 closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants