Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed vulnerabilities with ipfs and mocha #693

Merged
merged 3 commits into from Aug 1, 2022

Conversation

jimni1222
Copy link
Contributor

@jimni1222 jimni1222 commented Jul 26, 2022

Proposed changes

This PR fixes vulnerabilities through npm audit fix --force
After this PR, there is not any vulnerabilities issue.

스크린샷 2022-07-26 오후 2 53 25

  • Update ipfs-http-client library
    The latest ipfs library only supports ESM (please refer to this).
    Since the logic is changed to load ipfs with dynamic import function, caver.ipfs.setIPFSNode is changed to async function.
    This is a breaking change, so i write down it in the release notes.

  • Update mocha library
    The bin file name is changed, so i updated path in package.json file for running test code.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

closes #676

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jimni1222 jimni1222 requested a review from kjhman21 as a code owner July 26, 2022 05:55
@jimni1222 jimni1222 self-assigned this Jul 26, 2022
@kjhman21
Copy link
Contributor

@jimni1222 Don't we need to fix this?
image

@jimni1222
Copy link
Contributor Author

@kjhman21 I fixed that. Can you review?

Copy link
Contributor

@kjhman21 kjhman21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@jimni1222 jimni1222 merged commit 5e384bb into klaytn:dev Aug 1, 2022
@jimni1222 jimni1222 deleted the vulnerabilities branch August 1, 2022 13:21
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

security vulnerability dependabot alerts
2 participants