Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chaindatafetcher minor update #1302

Closed
jeongkyun-oh opened this issue Apr 5, 2022 · 3 comments
Closed

Chaindatafetcher minor update #1302

jeongkyun-oh opened this issue Apr 5, 2022 · 3 comments
Assignees
Projects

Comments

@jeongkyun-oh
Copy link
Contributor

jeongkyun-oh commented Apr 5, 2022

Range fetching API should be updated with meaningful parameters. Currently, the parameters are magic number (for blockground, tracegroup, or allgroup). This should be updated.


Chaindatafetcher message is better to update to make them consistent with the result of GetBlockWithConsensusInfo api.

The difference between kafka result and the api result is:

  • committee members (kafka include all council members, not only committee members)
  • round info (newly updated)
  • original proposer info (newly updated)

Block validator list (or council members) may be included as well if necessary.

@jeongkyun-oh jeongkyun-oh added the Task High level work unit for development. Task has several sub-tasks. label Apr 5, 2022
@jeongkyun-oh jeongkyun-oh added this to the v1.8.3 milestone Apr 5, 2022
@jeongkyun-oh jeongkyun-oh self-assigned this Apr 5, 2022
@jeongkyun-oh jeongkyun-oh added this to To do in Storage via automation Apr 5, 2022
@aidan-kwon
Copy link
Member

There is a requirement from consumer users. They want to get information about the deployed transaction's KIP/EIP implementation whether it implemented KIP7, ERC20, or other specifications.
It is not mandatory, but let's consider this too.

@jeongkyun-oh jeongkyun-oh modified the milestones: v1.8.3, v1.9.0 Apr 15, 2022
@jeongkyun-oh jeongkyun-oh modified the milestones: v1.9.0, v1.10.0 Jul 7, 2022
@jeongkyun-oh jeongkyun-oh removed this from the v1.10.0 (Kore) milestone Nov 3, 2022
@jeongkyun-oh jeongkyun-oh changed the title New Kafka Message Version 1.1 Chaindatafetcher Kafka message update Nov 6, 2022
@jeongkyun-oh jeongkyun-oh removed the Task High level work unit for development. Task has several sub-tasks. label Nov 8, 2022
@jeongkyun-oh jeongkyun-oh changed the title Chaindatafetcher Kafka message update Chaindatafetcher minor update Nov 8, 2022
Storage automation moved this from To do to Done Nov 8, 2022
@kjhman21 kjhman21 mentioned this issue Nov 9, 2022
31 tasks
@jeongkyun-oh
Copy link
Contributor Author

jeongkyun-oh commented Dec 1, 2022

Test for #1587

  • version: version: Klaytn v1.10.0+5025e0f61e
> chaindatafetcher.startRangeFetching(90000000, 90001000, 2)
Error: the request type is not valid
    at web3.js:3278:20
    at web3.js:6810:15
    at web3.js:5221:36
    at <anonymous>:1:1

> chaindatafetcher.startRangeFetching(90000000, 90001000, 48)
null
> chaindatafetcher.startRangeFetching(90000000, 90001000, 1)
Error: the request type is not valid
    at web3.js:3278:20
    at web3.js:6810:15
    at web3.js:5221:36
    at <anonymous>:1:1

> chaindatafetcher.startRangeFetching(90000000, 90001000, 48)
null
> chaindatafetcher.startRangeFetching(90000000, 90001000, "block")
null
> chaindatafetcher.startRangeFetching(90000000, 90001000, "trace")
null
> chaindatafetcher.startRangeFetching(90000000, 90001000, "all")
null
> chaindatafetcher.startRangeFetching(90000000, 90001000, "wrong")
Error: the request type should be 'all', 'block', 'trace', or uint type
    at web3.js:3278:20
    at web3.js:6810:15
    at web3.js:5221:36
    at <anonymous>:1:1

@jeongkyun-oh
Copy link
Contributor Author

jeongkyun-oh commented Dec 1, 2022

Test for #1611

  • version: Klaytn v1.10.0+5025e0f61e
  • checked newly added/original fields with Kafdrop.

스크린샷 2022-12-01 오후 4 55 20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants