Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous chainConfig API name #1615

Closed
hyunsooda opened this issue Aug 30, 2022 · 3 comments · Fixed by #1704
Closed

Ambiguous chainConfig API name #1615

hyunsooda opened this issue Aug 30, 2022 · 3 comments · Fixed by #1704
Assignees
Projects

Comments

@hyunsooda
Copy link
Contributor

hyunsooda commented Aug 30, 2022

Is your request related to a problem? Please describe.
The governance_chainConfig API name seems ambiguous because it prints only the initial chain configuration, not the currently activated values.

Describe the solution you'd like
How about renaming it more appropriately?

Describe alternatives you've considered
Such as initialChainConfig, etc.

Additional context

cc. @blukat29

@blukat29
Copy link
Contributor

I agree that the API name is misleading.
It's quite an old issue arisen since the development of the dynamic gas fee. (#1391)

In my opinion, in the long term the ChainConfig should be one of

  • the initial (genesis) values
  • the latest values
  • only immutable values (e.g. ChainID, *CompatibleBlock). Mutable fields are removed away.

I haven't decided which way should we go. We'll need experiments and discussions among the devs.

In the short term, however, we could

  • add governance_initialChainConfig API
  • promote using governance_initialChainConfig in the Klaytn docs, Forum Q&A, Discord, etc.

Will the short-term fix work for you? @hyunsooda

@hyunsooda
Copy link
Contributor Author

Both are fine for me. Can I close it? or would you close after you make a change?

@blukat29
Copy link
Contributor

blukat29 commented Sep 1, 2022

I'll close after making the change.

@blukat29 blukat29 self-assigned this Sep 1, 2022
@blukat29 blukat29 added this to To do in Governance via automation Sep 1, 2022
@blukat29 blukat29 changed the title Ambiguous API name Ambiguous chainConfig API name Oct 18, 2022
Governance automation moved this from To do to Done Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants