You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is no problem until 1.9.1, but Applying EIP-234 (#1653 appears to be a bug.
I need blockHash, so I cherry-picked the above PR.
However, after the cherry pick, I experienced a new bug.
// Convert the RPC block numbers into internal representations
The results of eth_newFilter & eth_getFilterLogs API and getLogs API are different with the same FilterQuery input. the begin and end specification in getlogs API does not work as intended.
If filter query has a range input, begin and end appear to go to zero.
now:
var (
begin int64
end int64
)
if crit.FromBlock == nil {
begin = int64(rpc.LatestBlockNumber)
}
if crit.ToBlock == nil {
end = int64(rpc.LatestBlockNumber)
}
// Construct the range filter
filter = NewRangeFilter(api.backend, begin, end, crit.Addresses, crit.Topics)
}
suggest:
begin := rpc.LatestBlockNumber.Int64()
if crit.FromBlock != nil {
begin = crit.FromBlock.Int64()
}
end := rpc.LatestBlockNumber.Int64()
if crit.ToBlock != nil {
end = crit.ToBlock.Int64()
}
How to reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Attachments
If applicable, add data, logs or screenshots to help explain your problem.
Environment (please complete the following information) 0e5c8c1
latest commit of dev branch
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered:
Describe the bug
There is no problem until 1.9.1, but Applying EIP-234 (#1653 appears to be a bug.
I need blockHash, so I cherry-picked the above PR.
However, after the cherry pick, I experienced a new bug.
klaytn/node/cn/filters/api.go
Line 372 in 0e5c8c1
The results of
eth_newFilter
ð_getFilterLogs
API andgetLogs
API are different with the sameFilterQuery
input. thebegin
andend
specification ingetlogs
API does not work as intended.If filter query has a range input,
begin
andend
appear to go to zero.now:
suggest:
How to reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Attachments
If applicable, add data, logs or screenshots to help explain your problem.
Environment (please complete the following information)
0e5c8c1
latest commit of dev branch
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: