Skip to content
This repository has been archived by the owner on Mar 19, 2021. It is now read-only.

Support for Scarab Pricing #31

Open
stephenhoran opened this issue Dec 31, 2018 · 5 comments
Open

Support for Scarab Pricing #31

stephenhoran opened this issue Dec 31, 2018 · 5 comments

Comments

@stephenhoran
Copy link

I attempted to add this support myself however I am unable to really determine the cause of this errors I am receiving. I added the following to parserTypes.json file under the Normal Array:

    {
      "regex": "Can be used in the Templar Laboratory or a personal Map Device to add modifiers to a Map.",
      "type": "Scarab"
    }

As well as extended the API's in the poe ninja api.

      {overview: "item", type: "Scarab"},

However still no luck, just a yellow icon, no errors logging.

Ninja supports: https://poe.ninja/api/data/itemOverview?league=Betrayal&type=Scarab

I will continue to try and hack on this but maybe I am missing something?

@klayveR
Copy link
Owner

klayveR commented Jan 1, 2019

You need to add the API url to the poe-ninja-module somewhere. I can't check exactly where right now but I'll update in a day or two.

@stephenhoran
Copy link
Author

@klayveR Interesting. I assumed that by updating the API's attribute of the NinjaAPI class in the poe-ninja-module would be enough to make the helper able to build the correct url based on type. I will have to see what you do to implement this to better understand.

@klayveR
Copy link
Owner

klayveR commented Jan 1, 2019

You're right, just checked again and that should work. Maybe the item isn't being parsed correctly or the query to fetch the price needs to be adjusted for scarabs. I currently only have access to a mobile device so I can't check this properly, but will do once I'm back home.

@stephenhoran
Copy link
Author

@klayveR Yes, very strange. I could not figure out how to log the http request itself as I am pretty new with electron and could not see any http events in the debugger. Thanks for the help! Love the tool, I use it daily!

@stephenhoran
Copy link
Author

@klayveR it appears this issue has returned in the new league :(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants