Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Header] Allow components in summary to be in front of buttons #1447

Open
rodolpheV opened this issue Sep 15, 2017 · 1 comment
Open

[Header] Allow components in summary to be in front of buttons #1447

rodolpheV opened this issue Sep 15, 2017 · 1 comment

Comments

@rodolpheV
Copy link
Contributor

Current implementation

Buttons and Summary are in different stacking contexts. The impact is that no components in Summary can be in front of buttons, especially popins.

Expected implementation

Put buttons and summary in the same stacking context. To do that, put them in a common div:

<HeaderScrolling>
       <div data-focus='sub-header'>
            <HeaderTopRow />
            <HeaderActions />
      </div>
      <HeaderContent />
</HeaderScrolling>

And set this common div as fixed with some z-index in data-deployed=false mode.

Versions

Focus-core: 2.1.1
Focus-components: 2.1.7-1

@Hartorn
Copy link
Contributor

Hartorn commented Sep 15, 2017

@rodolpheV
I agree, the whole header is messy for css stacks, position and so on.
Problem is to avoid regression at the same time.

@c3dr0x Could you give it a try ? There is also the thing with expanded or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants