Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon] Icon are resolved as text on IE #317

Closed
durandx opened this issue Sep 11, 2015 · 27 comments
Closed

[Icon] Icon are resolved as text on IE #317

durandx opened this issue Sep 11, 2015 · 27 comments
Assignees
Labels

Comments

@durandx
Copy link
Contributor

durandx commented Sep 11, 2015

Icon are resolved as text on IE:

With IE :

Secondary action

image
πŸ”΄ Fail

Scroll to top:

image
πŸ”΄ Fail

With Firefox:

Secondary action

image
πŸ”Ά Still a z-index problem with Block component

Scroll to top:

image
βœ… Success

@pierr
Copy link
Contributor

pierr commented Sep 12, 2015

Maybe a specific font file is missing. IE uses other fonts

@pierr pierr added the Question label Sep 12, 2015
@pierr pierr added this to the Focus-components v0.7.0 milestone Sep 12, 2015
@pierr pierr self-assigned this Sep 12, 2015
@pierr
Copy link
Contributor

pierr commented Sep 15, 2015

@pierr
Copy link
Contributor

pierr commented Sep 15, 2015

image

@pierr
Copy link
Contributor

pierr commented Sep 15, 2015

@Bernardstanislas @TomMaSS Any opinion on that?

@pierr
Copy link
Contributor

pierr commented Sep 15, 2015

Suggestion create a component Icon for ie9 with a mapping on components

@Bernardstanislas
Copy link
Contributor

πŸ‘

@durandx
Copy link
Contributor Author

durandx commented Sep 15, 2015

For Info, I have the bug with the version 11 of IE

/xxx/static/fonts/fontawesome-webfont.eot? HTTP GET 200 application/vnd.ms-fontobject 59,59 Ko 32 ms @font-face 561 0 16 16 0 20467

@pierr
Copy link
Contributor

pierr commented Sep 15, 2015

Maybe the probem is your server which does not know how to serve this specific font file...
Font awesome provide sevral fonts.

@pierr
Copy link
Contributor

pierr commented Sep 15, 2015

@durandx Maybe you can check https://github.com/google/material-design-icons/tree/master/iconfont which should be in the associated package.json file

@pierr pierr assigned durandx and unassigned pierr Sep 17, 2015
@pierr pierr added the Critical label Sep 25, 2015
@durandx
Copy link
Contributor Author

durandx commented Sep 25, 2015

@pierr
Copy link
Contributor

pierr commented Sep 25, 2015

<link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons">

@pierr
Copy link
Contributor

pierr commented Sep 25, 2015

This works on ie

@pierr pierr added the Wontfix label Sep 25, 2015
@TomGallon TomGallon removed this from the Focus-components v0.6.2 milestone Sep 28, 2015
@durandx
Copy link
Contributor Author

durandx commented Oct 7, 2015

Was working in our localhost and recette environnent.
Still working in localhost but not no more in recette environnement (google font update ?).

@pierr
Copy link
Contributor

pierr commented Oct 12, 2015

@Jerom138 maybe it is the same problem for old FF

@pierr
Copy link
Contributor

pierr commented Oct 12, 2015

@durandx Google has indeed published a new mdl lite version, we didn't upgrade in foocus components.

@pierr
Copy link
Contributor

pierr commented Oct 14, 2015

@pierbrisson

@pierr pierr added this to the Long term release (more than a month) milestone Oct 23, 2015
@pierr pierr added the Backlog label Nov 25, 2015
@Pandakls
Copy link
Contributor

Got the issue on both IE and FF, what do i have to do to fix this ?

@xuaveneg
Copy link
Contributor

xuaveneg commented Jan 6, 2016

Hi, I just updated focus-core and focus-components, and my icons are still not displayed on IE in recette environment (it works in localhost). How can I fix this ?

@TomGallon
Copy link
Contributor

did you add this line in the header of your index.html or JSP file ?

<link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons">

@xuaveneg
Copy link
Contributor

xuaveneg commented Jan 6, 2016

Sorry, now it's resolved.
The problem was that I didn't add material-design-icons-iconfont for IE compatibility.

@durandx
Copy link
Contributor Author

durandx commented Jan 8, 2016

Please can you explain what did you do in detail ?

@xuaveneg
Copy link
Contributor

xuaveneg commented Jan 8, 2016

With webpack and scss-loader,
I added the node.js module material-design-icons-iconfont to my project.
I imported the module in a js file with

import 'material-design-icons-iconfont/dist/material-design-icons.scss';

and then it worked.

@durandx
Copy link
Contributor Author

durandx commented May 24, 2016

We have switched to webpack (from brunch) 2 or 3 month ago, and the font is now correctly inlined in the css along with some localhost:3000/xx.eot url. With Chrome and Firefox, the inlined is taken, but with IE11 (and 10) the font use the localhost:3000 url.
@xuaveneg Does your solution is working with IE 11 ?

@pierr
Copy link
Contributor

pierr commented May 24, 2016

@durandx I helped @JRLK with a similar issue last week it was due to webpack config.
Maybe @JRLK can comment the solution on this issue.

@JRLK
Copy link
Contributor

JRLK commented May 25, 2016

@pierr We work only with Chrome not with IE.
The issue we looked together was about absolute and relative path to access to the fonts.
I don't think the issue @durandx is talking about is the same.

@durandx
Copy link
Contributor Author

durandx commented May 25, 2016

Linked to : #1125

@durandx
Copy link
Contributor Author

durandx commented May 25, 2016

Solution here : klee-contrib/webpack-focus#9

@TomGallon TomGallon modified the milestone: Long term release Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants