Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic translation in Focus success message #648

Closed
gideruette opened this issue Nov 4, 2015 · 3 comments
Closed

Dynamic translation in Focus success message #648

gideruette opened this issue Nov 4, 2015 · 3 comments

Comments

@gideruette
Copy link
Contributor

In a Focus.message.addSuccessMessage, I'd like to give some dynamic parameter like

Focus.message.addSuccessMessage('message.delete.success.', { count: '10'});

where :

[...] message: {success: {delete: '\__count\__ items has been successfully deleted'}}}

But my object parameter is not taken in consideration

I have to use I18n mixin instead :

Focus.message.addSuccessMessage(i18n.t('message.delete.success.', { count: '1'}));

@pierr
Copy link
Contributor

pierr commented Nov 4, 2015

Ok, this could be an enhancement, however being explicit on i18n is also a good thing.
This bug is related to focus-core

@pierr
Copy link
Contributor

pierr commented Nov 4, 2015

@gideruette don't hesitate to create a pull request on focus core. This is quite easy to implement.

@pierr pierr modified the milestones: Long term release (more than a month), Short term release (2 weeks) Nov 5, 2015
@pierr pierr added the Backlog label Nov 25, 2015
@TomGallon TomGallon modified the milestones: 3.0.0, Short term release Sep 5, 2016
@TomGallon TomGallon added v2.x.x and removed Backlog labels Sep 22, 2016
@TomGallon TomGallon modified the milestones: 2.0.0, 3.0.0 Sep 22, 2016
@GuenoleK GuenoleK assigned GuenoleK and unassigned pierr Oct 17, 2016
@GuenoleK
Copy link
Contributor

Bug due to focus-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants