Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with requesting next results #59

Closed
matesich opened this issue May 28, 2022 · 1 comment · Fixed by #60
Closed

Issue with requesting next results #59

matesich opened this issue May 28, 2022 · 1 comment · Fixed by #60
Labels
bug Something isn't working
Milestone
@klevu/core 1.1.1

Comments

@matesich
Copy link

Hi, there's a problem with next function's offset property, instead of adding the offset value as a number it gets appended as a string

view screenshots below:

Screenshot from 2022-05-28 22-44-46

Screenshot from 2022-05-28 22-45-06
@rallu rallu added the bug Something isn't working label May 30, 2022
@rallu
Copy link
Contributor

rallu commented May 30, 2022

Looks like the old fashioned JS bug. Luckily there is simple fix 😄

@rallu rallu mentioned this issue May 30, 2022
Merged
@rallu rallu added this to the @klevu/core 1.1.1 milestone May 30, 2022
@rallu rallu closed this as completed in #60 Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
@klevu/core 1.1.1
Development

Successfully merging a pull request may close this issue.

Change the way offset is calculated in next() function klevultd/frontend-sdk
2 participants
@rallu @matesich