Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIn-build Actions are expired - no downloads of any working builds that newer than 2.0.0rc8 #1295

Closed
DaLiV opened this issue Jan 8, 2023 · 9 comments · Fixed by #1308
Closed

Comments

@DaLiV
Copy link

DaLiV commented Jan 8, 2023

wanted to try latest versions for windows

  • latest throw exceptions
  • but all other previous builds are downloads "expired"
@DivingDuck
Copy link
Collaborator

Had you try this run?
https://github.com/kliment/Printrun/actions/runs/3682013645

Development versions from actions are only a limited time available and do expire.

@DaLiV
Copy link
Author

DaLiV commented Jan 9, 2023

Failed to execute due ...

Traceback (most recent call last):
File "pronterface.py", line 62, in
File "printrun\pronterface.py", line 2580, in init
File "printrun\pronterface.py", line 186, in init
wx._core.wxAssertionError: C++ assertion "strcmp(setlocale(0, 0), "C") == 0" failed at ....\src\common\intl.cpp(1699) in wxLocale::GetInfo(): You probably called setlocale() directly instead of using wxLocale and now there is a mismatch between C/C++ and Windows locale.
Things are going to break, please only change locale by creating wxLocale objects to avoid this!

OS: Win11-Home
installed Pythons (from MS-Store) : 3.8 ... but think that also not matter, as exe not related on system python-s

@DivingDuck
Copy link
Collaborator

Thanks for this info. This this seems to be the wxPython issue and happen to Windows 10 and 11 with some language setting combinations. I have a version where this is solved. You can try this interim version if you want:

https://github.com/DivingDuck/Printrun/actions/runs/3748727767

Scroll to the end of the page and download one of the artifacts. The number at the end of the file identify the python version used for compiling. This is the only difference.

This Wiki page list all changes compared to the latest release candidate:
https://github.com/DivingDuck/Printrun/wiki/My-latest-development-version-build-with-github-workflow
Feedback is welcome.

@DaLiV
Copy link
Author

DaLiV commented Jan 10, 2023

same for all (3.7-3.10)
gui has started but on [connect] - not connecting ... and no problem descriptions - empty traceback.

Connecting...
--- Logging error ---
Traceback (most recent call last):

During handling of the above exception, another exception occurred:
  • On Close (must terminate in task manager) :
Not connected to printer.
--- Logging error ---
Traceback (most recent call last):
  File "logging\__init__.py", line 1088, in emit
  File "printrun\pronterface.py", line 108, in write
AttributeError: 'NoneType' object has no attribute 'write'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "printrun\printcore.py", line 150, in logError
  File "printrun\pronsole.py", line 297, in logError
  File "logging\__init__.py", line 2049, in error
  File "logging\__init__.py", line 1475, in error
  File "logging\__init__.py", line 1589, in _log
  File "logging\__init__.py", line 1599, in handle
  File "logging\__init__.py", line 1661, in callHandlers
  File "logging\__init__.py", line 954, in handle
  File "logging\__init__.py", line 1093, in emit
  File "logging\__init__.py", line 1006, in handleError
  File "printrun\pronterface.py", line 108, in write
AttributeError: 'NoneType' object has no attribute 'write'

--- Logging error ---
Traceback (most recent call last):
During handling of the above exception, another exception occurred:
During handling of the above exception, another exception occurred:
During handling of the above exception, another exception occurred:

@DivingDuck
Copy link
Collaborator

Interesting, you are the the second person reporting this. Can you check the issue below?
DivingDuck#22
It seems like you have a defect printrunconf.ini. This happen usually if you switch between 1x and 2.x versions.

Please delete this file in:
c:\Users\Your_User_Name\
and delete the folder:
c:\Users\Your_User_Name\AppData\Local\Printrun\
as described.
Then open Pronterface and set the log file to an appropriate file name including the path information as I had shown. You need to have full read/write access to this location. Like:
c:\Users\Your_User_Name\Printrun.log

Your_User_Name = your windows user name

@DaLiV
Copy link
Author

DaLiV commented Jan 10, 2023

so ... that was "log file" issue
has tried to clean up LocalProfile before - not helped

so part with log helped

  • changed log location
  • killed (as tracebacks and not closing)
    = working

to solve / improve :
a) default = not to log, especially when no log file set (that must be advisable when software try to do that)
b) set default log location in %TEMP%, %LOCALAPPDATA%, %APPDATA% ... not in %USERPROFILE%
c) on unwriteable log - alert and open "create LOG file" dialog

@DivingDuck
Copy link
Collaborator

Thanks for your feedback, I appreciate that.
The original behavior was not to log if there is no logging file specified.
I'll take a look on that but I can't promise to change this as we do not have only windows users to consider here. In addition %LOCALAPPDATA%, %APPDATA% are hidden folders and usual users do not to see this locations in Explorer what cause additional problems / issue reports.

Anyway, I see the behavior of Pronterface had change and I can reproduce the issue with your information. There should be at least a check to prevent logging if there is no entry made.

Again, thanks for reporting.

@DivingDuck
Copy link
Collaborator

DivingDuck commented Jan 11, 2023

I had the chance to take a quick look on the issue. Pronterface should redirect all logging activities to console output if there is no log path specified.
Exact this happen if I run Pronterface directly from source code. Running Ponterface from the executable file will show an error if log path is not set.
This happen in the latest artifact builds here as well as in my latest builds local and via my repository.
I have no solution for this right now.
The work around for now is to set path and filename in log path to an appropriate location where the user have read/write access. Such as:
c:\Users\Your_User_Name\Printrun.log
(Your_User_Name = your windows user name)

@DivingDuck
Copy link
Collaborator

@DaLiV ,
it took a while to fix that problem as well, but now this issue is solved too with the latest updates we did for the repository here. You don't need to download the files from my repository as it is in sync with my updates. You can test and give us a feedback if you like so. Here is a link to the latest build.
https://github.com/kliment/Printrun/actions/runs/4152400998

I will close the issue and mark as completed (e66bbbd)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants