-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error of 2D viewer when loading gcode files with G2/G3 arcs #1433
Comments
Good catch. I had test this with 3D view as I had wrote a test macro for testing my firmware but never tried to test it in 2D view... Guess I know where the problem is. This came with Python 10 introduced stricter type verification. We had a lot of troubles with this in the past (e.g. #1224). It seems to be one of the so fare not identified parts of the code in this module. gviz.py, line 334+:
I will change this. Macro ArcModeG2G3:
|
Ready for test: https://github.com/kliment/Printrun/actions/runs/9549004098 |
That was superfast! And yes, works perfectly. |
Hi, I just noticed that when I use the 2D viewer and try to load a gcode file with G2 and G3 movements (arcs), then I get the following error message. And the visualisation fails.
As an example you can try this file from printables. But it seems to happen with all files that contain G2/G3 moves.
It is the same error on windows and macOS. It occurs from version 2.0.0 but NOT in version 2.0.0rc8.
Probably pretty easy to fix.
The text was updated successfully, but these errors were encountered: