Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

May fail in Shiny with weird function names #69

Closed
klmr opened this issue Sep 28, 2015 · 0 comments
Closed

May fail in Shiny with weird function names #69

klmr opened this issue Sep 28, 2015 · 0 comments
Assignees
Milestone

Comments

@klmr
Copy link
Owner

klmr commented Sep 28, 2015

Currently, the code checks for Shiny by walking the call stack, looking for a call to shiny::runApp.

There are two caveats:

  1. As mentioned in a user group discussion, this may fail when runApp is invoked differently (which could happen).
  2. Even without any change in the invocation, there may be convoluted situations where multiple functions called runApp are on the call stack. In such cases, the check will fail.
@klmr klmr self-assigned this Sep 28, 2015
@klmr klmr modified the milestone: 1.0 Jul 15, 2016
@klmr klmr closed this as completed in c7cf05c Sep 9, 2017
@klmr klmr reopened this Sep 25, 2017
@klmr klmr closed this as completed Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant