Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dna4_count_mismatches_rev #8

Closed
Tracked by #18
kloetzl opened this issue Aug 18, 2020 · 2 comments
Closed
Tracked by #18

dna4_count_mismatches_rev #8

kloetzl opened this issue Aug 18, 2020 · 2 comments
Labels
new functionality New feature or request
Milestone
v1.2

Comments

@kloetzl
Copy link
Owner

kloetzl commented Aug 18, 2020

Counting substitutions is already implemented in dna4_count_mismatches. However, DNA has two strands. When the two strings come from different strains, a new function can be useful. An example implementation is build in phylonium.
@kloetzl kloetzl added the new functionality New feature or request label Aug 18, 2020
@kloetzl kloetzl added this to the v1.1 milestone Aug 18, 2020
@kloetzl kloetzl modified the milestones: v1.1, v1.2 Mar 28, 2021
@kloetzl
Copy link
Owner Author

kloetzl commented Dec 18, 2021

I'm wondering which is the best name:

  • dna4_count_mismatches_rev
  • dna4_count_mismatches_revcomp
  • dna4_count_mismatches_rc

@kloetzl kloetzl mentioned this issue Mar 10, 2022
Closed
6 tasks
@kloetzl
Copy link
Owner Author

kloetzl commented Mar 12, 2022 •
edited

  • implementation mostly done
  • avx2 implementation
  • rename
  • ifunc tests

@kloetzl kloetzl closed this as completed Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new functionality New feature or request
Projects
None yet
Milestone
v1.2
Development

No branches or pull requests
1 participant
@kloetzl