New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reading tweaks, and fix build #19
Conversation
* Fix a typo with numbering of sequential items (1,2,3 _vs_ 1,2,4) * Move logo to right, flow text around it * Scale logo (% _vs_ pt) so it looks right on any device * IntelliJ reformatted the text layout * A grammar tweak Note: When Klogging has an independent site (_eg_, like Batect), the logo can be wrapped with an anchor tag for each one-click access.
Heh ... my commit msg itself has a typo. |
NOTE Apologies for mixing things in a single PR. Since this PR is off of Fix build commit simply results from running the |
README.md
Outdated
|
||
No other library I could find meets these requirements. | ||
|
||
### Why not … ? | ||
|
||
#### Logback / Log4j | ||
|
||
These venerable Java libraries have formed the backbone of Java logging for more than 10 years. The | ||
limitations I find are: | ||
These solid, but venerable Java libraries and have formed the backbone of Java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don’t need ‘and’ in this version of the sentence.
docs/Configuration.md
Outdated
@@ -89,7 +89,7 @@ loggingConfiguration(append = true) { | |||
|
|||
### `sink` | |||
|
|||
This function configures a named sink with a renderer and a dispatcher. | |||
This function configures a named sink with a renderer and a dispatcher. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whitespace was unintentional and I forgot to run spotlessApply
before committing.
But I changed the Spotless config to allow whitespace at the end of lines because it has meaning in Markdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's cool to learn -- thanks!
Latest commit -- fixed embarrassing grammar error. I need to proof-read better. And folks wonder at the value of pairing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @binkley
Note: When Klogging has an independent site (eg, like Batect), the
logo can be wrapped with an anchor tag for each one-click access.