Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading tweaks, and fix build #19

Merged
merged 6 commits into from Aug 3, 2021
Merged

Reading tweaks, and fix build #19

merged 6 commits into from Aug 3, 2021

Conversation

binkley
Copy link

@binkley binkley commented Aug 2, 2021

  • Fix a typo with numbering of sequential items (1,2,3 vs 1,2,4)
  • Move logo to right, flow text around it
  • Scale logo (% vs pt) so it looks right on any device
  • IntelliJ reformatted the text layout
  • A grammar tweak

Note: When Klogging has an independent site (eg, like Batect), the
logo can be wrapped with an anchor tag for each one-click access.

* Fix a typo with numbering of sequential items (1,2,3 _vs_ 1,2,4)
* Move logo to right, flow text around it
* Scale logo (% _vs_ pt) so it looks right on any device
* IntelliJ reformatted the text layout
* A grammar tweak

Note: When Klogging has an independent site (_eg_, like Batect), the
logo can be wrapped with an anchor tag for each one-click access.
@binkley
Copy link
Author

binkley commented Aug 2, 2021

Heh ... my commit msg itself has a typo.
for each one-click access should be for easy one-click access. :)

@binkley binkley changed the title Reading tweaks Reading tweaks, and fix build Aug 2, 2021
@binkley
Copy link
Author

binkley commented Aug 2, 2021

NOTE Apologies for mixing things in a single PR. Since this PR is off of binkley/main branch, when I push to that branch, it shows up in this PR.

Fix build commit simply results from running the spotlessApply task. The only change in that commit is to remove trailing whitespace in an MD file.

README.md Outdated

No other library I could find meets these requirements.

### Why not … ?

#### Logback / Log4j

These venerable Java libraries have formed the backbone of Java logging for more than 10 years. The
limitations I find are:
These solid, but venerable Java libraries and have formed the backbone of Java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don’t need ‘and’ in this version of the sentence.

@@ -89,7 +89,7 @@ loggingConfiguration(append = true) {

### `sink`

This function configures a named sink with a renderer and a dispatcher.
This function configures a named sink with a renderer and a dispatcher.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whitespace was unintentional and I forgot to run spotlessApply before committing.

But I changed the Spotless config to allow whitespace at the end of lines because it has meaning in Markdown.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool to learn -- thanks!

@binkley
Copy link
Author

binkley commented Aug 3, 2021

Latest commit -- fixed embarrassing grammar error. I need to proof-read better. And folks wonder at the value of pairing!

Copy link
Member

@mjstrasser mjstrasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @binkley

@mjstrasser mjstrasser merged commit 7510f24 into klogging:main Aug 3, 2021
mjstrasser added a commit that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants