Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#17 Updates jacoco configuration for multiplatform project #56

Merged
merged 1 commit into from Oct 13, 2021
Merged

#17 Updates jacoco configuration for multiplatform project #56

merged 1 commit into from Oct 13, 2021

Conversation

ashishkujoy
Copy link
Contributor

The issue is with jacoco configuration, with existing configuration jacoco was not able to generate report for kotlin multiplatform project.

Reference: https://stackoverflow.com/questions/59802396/kotlin-multiplatform-coverage
Coverage Report: https://codecov.io/github/ashishkujoy/klogging/commit/7702016938f7c55c0f117db48385d8e30bbf9caf

@ashishkujoy
Copy link
Contributor Author

@mjstrasser In case this pull request is good to merge could u please add hacktoberfest-accepted label to it, so it can be counted towards hactoberfest contribution.

@codecov-commenter
Copy link

Codecov Report

Merging #56 (7702016) into main (b94228d) will increase coverage by 85.94%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #56       +/-   ##
===========================================
+ Coverage        0   85.94%   +85.94%     
- Complexity      0       98       +98     
===========================================
  Files           0       67       +67     
  Lines           0     2163     +2163     
  Branches        0      143      +143     
===========================================
+ Hits            0     1859     +1859     
- Misses          0      231      +231     
- Partials        0       73       +73     
Impacted Files Coverage Δ
src/commonMain/kotlin/io/klogging/Level.kt 41.66% <0.00%> (ø)
...mTest/kotlin/io/klogging/context/LogContextTest.kt 74.28% <0.00%> (ø)
...c/commonMain/kotlin/io/klogging/config/Defaults.kt 100.00% <0.00%> (ø)
src/commonMain/kotlin/io/klogging/Klogging.kt 85.71% <0.00%> (ø)
...c/commonMain/kotlin/io/klogging/sending/SendElk.kt 65.00% <0.00%> (ø)
...monMain/kotlin/io/klogging/rendering/RenderAnsi.kt 53.33% <0.00%> (ø)
...ommonMain/kotlin/io/klogging/context/LogContext.kt 89.47% <0.00%> (ø)
...monMain/kotlin/io/klogging/config/LoggingConfig.kt 70.00% <0.00%> (ø)
...commonMain/kotlin/io/klogging/config/LevelRange.kt 100.00% <0.00%> (ø)
src/commonMain/kotlin/io/klogging/NoCoLogger.kt 0.00% <0.00%> (ø)
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b94228d...7702016. Read the comment docs.

@mjstrasser mjstrasser merged commit e5d1227 into klogging:main Oct 13, 2021
@mjstrasser
Copy link
Member

Thanks @ashishkujoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants