Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Update Suggestion (16 zone branch): section_status_last_run.yaml #27

Closed
ekkesa opened this issue Sep 9, 2020 · 2 comments
Closed

Comments

@ekkesa
Copy link

ekkesa commented Sep 9, 2020

Hi,

I believe this might have been overlooked in @athan71 16 zone branch.

For the 'Details of last run' to show dynamically correctly as the number of zones changes the following code needs to be added in '/config/lovelace/templates/garden/status/last_run/section_status_last_run.yaml'. Similiar code is already in the 'History Totals' section.

  - !include
      - item_status_last_run_line.yaml
      - entity: input_text.irrigation_zone9_previous_duration_in_seconds
        zone: zone9
        
  - !include
      - item_status_last_run_line.yaml
      - entity: input_text.irrigation_zone10_previous_duration_in_seconds
        zone: zone10
        
  - !include
      - item_status_last_run_line.yaml
      - entity: input_text.irrigation_zone11_previous_duration_in_seconds
        zone: zone11
        
  - !include
      - item_status_last_run_line.yaml
      - entity: input_text.irrigation_zone12_previous_duration_in_seconds
        zone: zone12
        
  - !include
      - item_status_last_run_line.yaml
      - entity: input_text.irrigation_zone13_previous_duration_in_seconds
        zone: zone13
        
  - !include
      - item_status_last_run_line.yaml
      - entity: input_text.irrigation_zone14_previous_duration_in_seconds
        zone: zone14
        
  - !include
      - item_status_last_run_line.yaml
      - entity: input_text.irrigation_zone15_previous_duration_in_seconds
        zone: zone15
        
  - !include
      - item_status_last_run_line.yaml
      - entity: input_text.irrigation_zone16_previous_duration_in_seconds
        zone: zone16
@davewatson91
Copy link
Contributor

This looks like @athan71 has already implemented this.. Figured best to followup since itappears @kloggy doesn't use GitHub for more than a repository.

@davewatson91
Copy link
Contributor

@ekkesa I've actually rewritten the work that @athan71 undertook to suit the latest bunch of changes, and done a new PR for @kloggy when he gets a chance to implement. I think this issue could be closed 👍🏼

@kloggy kloggy closed this as completed Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants