Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for Student model's first_name field. #75

Open
harisibrahimkv opened this issue Apr 21, 2017 · 1 comment
Open

Default value for Student model's first_name field. #75

harisibrahimkv opened this issue Apr 21, 2017 · 1 comment
Assignees

Comments

@harisibrahimkv
Copy link
Contributor

0244358#diff-690df693064f3c683737794f9d6c9b15L104

The null=True constraint for the first_name field was dropped from the Student model on that commit. However, when creating migrations, Django requires a default value to be either specified on the model definition itself or specified as a one-off-value while the migrations are being run.

I've specified it as the string "one-off-value" itself for all the first_name fields that were null (so that we can query for the string and get all the records). We'll have to decide what to do with it. Most probably just replace it with empty strings since those fields were anyway Null.

@harisibrahimkv harisibrahimkv changed the title Default value for Student models's first_name field. Default value for Student model's first_name field. Apr 21, 2017
@shivangi
Copy link
Collaborator

Yeah that is what i did when i ran it at my end too.
With SSA data coming in, I am assuming that the data will have to be cleaned and we can make sure this one of the checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants