Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to latest AndroidX #460

Closed
wants to merge 1 commit into from
Closed

Migration to latest AndroidX #460

wants to merge 1 commit into from

Conversation

adityasonel
Copy link

Whenever anyone tries to use react-native-gesture-handler with the latest android sdk library simply AndroidX. We got the error for old appcompat libraries used.

Then the developer has to manually remove older appcompat libraries and to add new androidx libraries. That's I created this PR with migrating react-native-gesture-handler to androidx.

@osdnk
Copy link
Contributor

osdnk commented Feb 12, 2019

@krzysztofciombor,
What do you think?

@osdnk
Copy link
Contributor

osdnk commented Feb 12, 2019

@adityasonel
I will be happy to merge it. However, could you fix e2e? Why is it breaking?

@adityasonel
Copy link
Author

@osdnk
let me check what is this issue.

@adityasonel
Copy link
Author

Actually, these errors are getting on @kmagiera branch, you have to migrate all your android's appcompat dependencies to android-x.

@osdnk
Copy link
Contributor

osdnk commented Feb 26, 2019

@adityasonel I'd like to wait for RN switch to AndroidX until changing it in RNGH. It requires target set to 28 and RN has made switch to 28 only 13 days ago (on master), so I'm not sure if I want to change it right now.

@FibreFoX
Copy link

Just for reference, pull-request #410 contains similar changes.

@adityasonel
Copy link
Author

@FibreFoX I am stucked in the same problem as #410. I don't know why Travis is failing.

@isaax2
Copy link

isaax2 commented Jul 4, 2019

In the meanwhile you can use
https://github.com/mikehardy/jetifier

npm install --save-dev jetifier
npx jetify

It will rewrite your local node_modules android packages to AndroidX

@jakub-gonet
Copy link
Member

This is fixed on master, thanks for contributing to RNGH 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants