Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal support for other platforms #16

Merged
merged 1 commit into from Sep 25, 2018

Conversation

Minishlink
Copy link
Contributor

Such as web and windows. requireNativeComponent is undefined on web.

This lives as a patch on DailyScrum - web version.

Such as web, windows...
Copy link
Member

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Minishlink

I think this also closes #13

@kmagiera kmagiera merged commit cf695ff into software-mansion:master Sep 25, 2018
@brunolemos
Copy link
Contributor

brunolemos commented Oct 2, 2018

This did not fix it on web for me. It still gives this error:

'react-native' does not contain an export named 'requireNativeComponent'.

Which is the same error reported here: react-navigation/react-navigation#5004

Necolas explained that this import should not be on any file that runs on web: necolas/react-native-web#507 (comment)

Made #22 with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants