Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

several npm warnings when installing ^1.1.0 #8

Closed
softprops opened this issue Dec 24, 2018 · 3 comments
Closed

several npm warnings when installing ^1.1.0 #8

softprops opened this issue Dec 24, 2018 · 3 comments
Assignees
Labels

Comments

@softprops
Copy link

given

    "dependencies": {
        "node-pagerduty": "^1.1.0",
    }

I get warnings about a request library that is not installed by default which is a bit confusing

npm i
npm WARN request-promise-core@1.1.1 requires a peer of request@^2.34 but none is installed. You must install peer dependencies yourself.
npm WARN request-promise-native@1.0.5 requires a peer of request@^2.34 but none is installed. You must install peer dependencies yourself.

after manually adding "request": "^2.88.0" to my dependencies

I see the following warnings

found 8 moderate severity vulnerabilities
  run `npm audit fix` to fix them, or `npm audit` for details

most of these seem to relate to node-pagerduty > request > hawk

I'm newish to node dependency management. Are these warnings expected?

@kmart2234
Copy link
Collaborator

I will take a look at this.

@kmart2234 kmart2234 added the bug label Jan 2, 2019
@kmart2234 kmart2234 self-assigned this Jan 2, 2019
@kmart2234
Copy link
Collaborator

This issue is resolved in version 1.1.1

@softprops
Copy link
Author

verified in my project. thanks @kmart2234 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants