Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 12 build errors #66

Closed
warpling opened this issue Jul 6, 2020 · 8 comments
Closed

Xcode 12 build errors #66

warpling opened this issue Jul 6, 2020 · 8 comments

Comments

@warpling
Copy link

warpling commented Jul 6, 2020

Since updating and attempting to compile with Xcode 12 beta I've getting build errors from McPicker for these two functions
public class func flexibleSpace() -> McPickerBarButtonItem
public class func fixedSpace(width: CGFloat) -> McPickerBarButtonItem

@warpling
Copy link
Author

warpling commented Jul 6, 2020

If anyone needs a branch that fixes this in the time being: https://github.com/warpling/McPicker-iOS

@cerupcat
Copy link

@warpling, with your version I'm getting Cannot override a Self return type with a non-Self return type with Xcode 12 Beta 4.

Looks like it needs to return Self and not McPickerBarButtonItem

@warpling
Copy link
Author

Huh, strange. I didn't have to change that to be able to compile with Swift 5 in Xcode 12 (not sure which beta).

@UtkuDalmaz
Copy link

How to fix this man? Cannot override a Self return type with a non-Self

@warpling
Copy link
Author

@UtkuDalmaz not sure. I just accepted the changes Xcode suggested and it compiled for me.

@cerupcat
Copy link

It may also depend on what you're using.

For me, with SPM and XcodeBeta 4/5, I needed to change 2 files that it was complaining about. The changes made though are different than in @warpling branch. If I get a chance, I'll make a branch.

@kmcgill88
Copy link
Owner

Started on a fix for this. Checkout #69 comments more than welcome!

@kmcgill88
Copy link
Owner

3.0.0 has been published and requires xcode 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants