New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TargetingInfo] Added targeting info to the newest version (WeTransfer link + File in the post) #162
Comments
I can make the pull request and implement it. |
@yiss Yes, do it please :) |
Whats up @yiss and @Nikolak47 I'm sorry I've been busy with my day job. If you have a solid solution for targeting please PR it. I'll be getting back to this project soon. I'm also going to need web support! |
Hi @kmcgill88 we totally understand no worries. I'm happy to help |
I would love to see this feature implemented. I'm currently using a fork which adds an optional parameter "personalizedAds" to comply with the GDPR. |
@davidmartos96 can you link this fork please so that I can take a look at it ? |
@yiss Sure, it's https://github.com/js2702/admob_flutter and the branch |
Here is the pull request #164 I added the same AdRequestFactoryBuilder used by the official Flutter admob plugin the modifications work fine I tested it on my mobile device : https://drive.google.com/file/d/1eNftPAGkBXPnX8vRRs1lReMTYj83Vqt-/view |
@yiss Can you tell me how to use it ?
|
@Nikolak47 I use
And then I use it
And for the Banner :
I forgot to update the main.dart in example I just did :) cheers |
Normally if it's working properly it should print |
@Nikolak47 let me know if that worked for you |
@yiss Thanks for the example. |
@Nikolak47 are you using your version or mine? Because in yours you haven't implemented targetingInfo for interstitial. I did it for the interstitial and reward ad you can check it on my github : https://github.com/yiss/admob_flutter the last commit is what you need. Waiting for the PR to be merged |
@Nikolak47 weird, can you show me the console output? Does it say anything? |
@Nikolak47 Erro 3 means that the request was successful but there is no Ad to serve this can be caused by many reasons. Can you test your interstitial with the one here : https://developers.google.com/admob/android/test-ads |
@yiss Thank you very much, it works! |
Alright! That's good news to hear. Glad I can help |
Hi, |
@cyberlahy yes by default it's non personalised, I made a PR waiting for it to be merged. You can check out my fork it contains the proper working version |
@yiss I see your code and I think it's by default "personalized" and we need to precise if it is not. Or I am wrong? |
@cyberlahy by the default targetingInfo is not required, when specify targetingInfo property you're then doing a personalized ads, example : |
Hey!
I just added targetingInfo (from the guy who failed to merge) to the newest state of the package.
Too lazy to make a pull request, so I'll just upload the zip file, for someone to do it.
Package (WeTransfer link):
https://we.tl/t-SfTm7GqAmu
If you find any problems/bugs, message me.
Will be glad if this is added to the newest version.
As file:
admob_flutter-withTargetingInfo.zip
The text was updated successfully, but these errors were encountered: