Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

Implementing the -diffs flag. #6

Closed
kminehart opened this issue Apr 10, 2017 · 1 comment
Closed

Implementing the -diffs flag. #6

kminehart opened this issue Apr 10, 2017 · 1 comment

Comments

@kminehart
Copy link
Owner

kminehart commented Apr 10, 2017

-diffs is supposed to only run tests on projects that have been changed in this commit.

The original plan said that "if a file was changed in this commit, then run the stage(s) for the project it is in."

However, there's an issue with that. If the test fails, and the developer goes on to modify another project, then the tests won't run for that project until it is modified again, leading to false positives.

One proposed solution would be to make the diffs based on branches.

jules test -diff origin/master
@kminehart
Copy link
Owner Author

HOWEVER that would not work for building on changes made on master, as the diff would always be 0. You could configure only master to run it with HEAD~1 of origin/master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant