Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.rspec config looks ignored even in Regular Mode #102

Closed
tnir opened this issue Mar 3, 2021 · 2 comments
Closed

.rspec config looks ignored even in Regular Mode #102

tnir opened this issue Mar 3, 2021 · 2 comments

Comments

@tnir
Copy link
Contributor

tnir commented Mar 3, 2021

.rspec config looks ignored even in Regular Mode (with knapsack_pro Gem, or with knapsack Gem) while knapsack_pro gem docs shows (only) Queue Mode ignore .rspec config: KnapsackPro/knapsack_pro-ruby@321de44

@ArturT
Copy link
Member

ArturT commented Mar 3, 2021

Hi @tnir

knapsack_pro gem in Regular Mode uses a rake task to start RSpec process. RSpec reads .rspec file. I've just tested it now to double check and I confirm the .rspec flags are respected for RSpec in knapsack_pro Regular Mode.

In knapsack_pro Queue Mode the RSpec is started via RSpec::Core::Runner class and then .rspec file is not respected by the RSpec. You need to pass arguments manually as described here
https://knapsackpro.com/faq/question/why-when-i-use-queue-mode-for-rspec-then-rspec-config-is-ignored

In knapsack gem the RSpec process is started via shell command so the .rspec file should be respected.

You can learn more about how knapsack_pro works in Regular Mode vs Queue Mode.

@ArturT ArturT closed this as completed Mar 3, 2021
@tnir
Copy link
Contributor Author

tnir commented Apr 27, 2021

@ArturT Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants