-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push Timecop to development dependencies #55
Comments
It is used here: def now_without_mock_time
Time.now_without_mock_time
end
Anyway thanks for checking :) |
Note to myself. It was done this way on purpose. Timecop is a regular dependency and I don't want to use Here is related commit in knapsack_pro KnapsackPro/knapsack_pro-ruby@f6fe6a2/knapsack_pro.gemspec#diff-0 |
I figured out how A similar thing could be done here in first-timers-only infoThis could be an easy task for someone new who would like to contribute to open source. Tips for first timers how to make pull request https://github.com/CPAN-PRC/resources/wiki/My-first-Pull-Request |
Moves Timecop to development dependency, Issue #55
In the gemspec the Timecop gem is listed as a regular dependency:
You probably want to include it only as a development dependency since it's only being used in
spec/knapsack/tracker_spec.rb
:https://github.com/ArturT/knapsack/search?utf8=%E2%9C%93&q=Timecop&type=
The text was updated successfully, but these errors were encountered: