Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to upgrade Sarama To v1.30.0 #1421

Closed
odacremolbap opened this issue Nov 6, 2021 · 2 comments
Closed

Need to upgrade Sarama To v1.30.0 #1421

odacremolbap opened this issue Nov 6, 2021 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@odacremolbap
Copy link

Describe the bug

Eventing e2e is failing due to dependency updates resolving Sarama to v1.30.0.
See sibling issue at eventing-kafka:

That same upgrade should also happen at eventing-kafka-broker. This is one of the eventing PR logs showing the issue:

https://github.com/knative/eventing/runs/4120996132?check_suite_focus=true

# knative.dev/eventing-kafka-broker/control-plane/pkg/kafka [knative.dev/eventing-kafka-broker/control-plane/pkg/kafka.test]
control-plane/pkg/kafka/consumer_group_lag_test.go:136:117: cannot use tc.client (type *saramaClientMock) as type sarama.ClusterAdmin in return argument:
	*saramaClientMock does not implement sarama.ClusterAdmin (missing AlterClientQuotas method)
ok  	knative.dev/eventing-kafka-broker/control-plane/pkg/core/config	0.002s
FAIL	knative.dev/eventing-kafka-broker/control-plane/pkg/kafka [build failed]
?   	knative.dev/eventing-kafka-broker/control-plane/pkg/logging	[no test files]
ok  	knative.dev/eventing-kafka-broker/control-plane/pkg/receiver	0.001s
# knative.dev/eventing-kafka-broker/control-plane/pkg/reconciler/kafka/testing
control-plane/pkg/reconciler/kafka/testing/admin_mock.go:27:5: cannot use &MockKafkaClusterAdmin{} (type *MockKafkaClusterAdmin) as type sarama.ClusterAdmin in assignment:
	*MockKafkaClusterAdmin does not implement sarama.ClusterAdmin (missing AlterClientQuotas method)
ok  	knative.dev/eventing-kafka-broker/control-plane/pkg/reconciler/base	0.001s
FAIL	knative.dev/eventing-kafka-broker/control-plane/pkg/reconciler/broker [build failed]
ok  	knative.dev/eventing-kafka-broker/control-plane/pkg/reconciler/channel	0.003s
FAIL	knative.dev/eventing-kafka-broker/control-plane/pkg/reconciler/kafka [build failed]
FAIL	knative.dev/eventing-kafka-broker/control-plane/pkg/reconciler/sink [build failed]
FAIL	knative.dev/eventing-kafka-broker/control-plane/pkg/reconciler/source [build failed]

Expected behavior

Implement new interface for Sarama v1.30.0 libray.

Knative release version

knative-v1.0.0

@odacremolbap odacremolbap added the kind/bug Categorizes issue or PR as related to a bug. label Nov 6, 2021
@pierDipi pierDipi closed this as completed Nov 9, 2021
@pierDipi
Copy link
Member

pierDipi commented Nov 9, 2021

Done in #1435

@pierDipi
Copy link
Member

pierDipi commented Nov 9, 2021

Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants