Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and migrate KafkaChannel secret format to Broker/Sink secret format #2231

Open
pierDipi opened this issue May 27, 2022 · 2 comments
Labels
area/channel Kafka Channel related issues kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@pierDipi
Copy link
Member

pierDipi commented May 27, 2022

Problem

The KafkaChannel secret format is using some different keys, as discussed in #2213, we should align it to the Broker and Sink format.
In #2224 we added support for the old format only.

Persona:
Which persona is this feature for?

  • users (maintainers as well)

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional):
How many developer-days do you think this may take to resolve?
1

Additional context (optional)

/area channel
/triage accepted

@aliok
Copy link
Member

aliok commented Jun 7, 2022

I thought this is working out of the box.

Did you remove the code that reads the new format with #2224 @pierDipi ?

We should fallback if for example, protocol is missing.

@pierDipi
Copy link
Member Author

pierDipi commented Jun 7, 2022

I didn't remove the code (it's still there because we need it for broker) but I didn't add the fallback logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/channel Kafka Channel related issues kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

2 participants