New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Retry Config to EgressConfig during broker reconciliation #263
Add Retry Config to EgressConfig during broker reconciliation #263
Conversation
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
============================================
+ Coverage 76.30% 76.76% +0.45%
Complexity 170 170
============================================
Files 49 49
Lines 1435 1463 +28
Branches 46 46
============================================
+ Hits 1095 1123 +28
Misses 271 271
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
33a7c7b
to
d50cd91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
d50cd91
to
875d036
Compare
/cc slinkydeveloper |
Maven error
/retest |
Probes use the embedded metrics server because we don't have a server on the dispatcher side. Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
The following is the coverage report on the affected files.
|
|
I checked and it should just work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…icied (knative-extensions#263) Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
…icied (knative-extensions#263) Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Part of #116
Proposed Changes
Release Note