Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Retry Config to EgressConfig during broker reconciliation #263

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Oct 7, 2020

Part of #116

Proposed Changes

  • Add Retry Config to EgressConfig during broker reconciler

Release Note

- 🧽 Update or clean up current behavior
The control plane sends retry configurations to the data plane.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 7, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 7, 2020
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #263 into master will increase coverage by 0.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #263      +/-   ##
============================================
+ Coverage     76.30%   76.76%   +0.45%     
  Complexity      170      170              
============================================
  Files            49       49              
  Lines          1435     1463      +28     
  Branches         46       46              
============================================
+ Hits           1095     1123      +28     
  Misses          271      271              
  Partials         69       69              
Flag Coverage Δ Complexity Δ
#java-unittests 76.05% <ø> (ø) 170.00 <ø> (ø)
#unittests 76.76% <100.00%> (+0.45%) 170.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
control-plane/pkg/config/env_config.go 90.00% <100.00%> (+10.00%) 0.00 <0.00> (ø)
control-plane/pkg/core/config/utils.go 75.00% <100.00%> (+29.54%) 0.00 <0.00> (ø)
control-plane/pkg/reconciler/broker/broker.go 80.47% <100.00%> (+1.22%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77aab31...a166e78. Read the comment docs.

@pierDipi pierDipi force-pushed the KNATIVE-116-control-plane branch 2 times, most recently from 33a7c7b to d50cd91 Compare October 7, 2020 09:59
Copy link
Contributor

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi
Copy link
Member Author

pierDipi commented Oct 7, 2020

/cc slinkydeveloper

@pierDipi
Copy link
Member Author

pierDipi commented Oct 7, 2020

Maven error

[ERROR] Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.6:prepare-agent (default) on project data-plane: Execution default of goal org.jacoco:jacoco-maven-plugin:0.8.6:prepare-agent failed: Plugin org.jacoco:jacoco-maven-plugin:0.8.6 or one of its dependencies could not be resolved: Could not transfer artifact org.apache.maven.shared:file-management:jar:1.2.1 from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar: Connection reset -> [Help 1]

/retest

Probes use the embedded metrics server because we don't have a
server on the dispatcher side.

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-broker-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
control-plane/pkg/config/env_config.go 80.0% 90.0% 10.0
control-plane/pkg/core/config/utils.go 75.0% 92.9% 17.9
control-plane/pkg/reconciler/broker/broker.go 88.8% 89.6% 0.8

@pierDipi
Copy link
Member Author

pierDipi commented Oct 7, 2020

I can't update only the control plane 🤦
/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2020
@pierDipi
Copy link
Member Author

pierDipi commented Oct 7, 2020

I checked and it should just work.
/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2020
Copy link
Contributor

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pierDipi,slinkydeveloper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit c0c8682 into knative-extensions:master Oct 7, 2020
@pierDipi pierDipi deleted the KNATIVE-116-control-plane branch April 14, 2021 21:16
pierDipi added a commit to pierDipi/eventing-kafka-broker that referenced this pull request May 11, 2022
…icied (knative-extensions#263)

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
matzew pushed a commit to matzew/eventing-kafka-broker that referenced this pull request May 11, 2022
…icied (knative-extensions#263)

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
knative-prow bot pushed a commit that referenced this pull request May 16, 2022
…icied (#263) (#2185)

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants