Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Trigger Scaling with KEDA through annotations #3811

Open
Cali0707 opened this issue Apr 4, 2024 · 3 comments
Open

Configure Trigger Scaling with KEDA through annotations #3811

Cali0707 opened this issue Apr 4, 2024 · 3 comments
Labels
kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@Cali0707
Copy link
Member

Cali0707 commented Apr 4, 2024

Problem
Currently, users can configure KEDA scaling options through annotations when creating a KafkaSource. We should support the same set of annotations on triggers.

Persona:
Which persona is this feature for?

Exit Criteria
Scaling for triggers can be configured through annotations with the same API as KafkaSources

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1-2

Additional context (optional)
Add any other context about the feature request here.

@Cali0707
Copy link
Member Author

Cali0707 commented Apr 4, 2024

@pierDipi what do you think of allowing users to also set the annotations on the broker? I could see this maybe being easier, rather than needing to set it on each trigger. This would be the following behaviour then:

  1. If there is an annotation on the trigger, use those values
  2. If there is no annotation on the trigger, but there is an annotation on the broker, use the broker annotation
  3. Otherwise, use the default values

@Cali0707
Copy link
Member Author

Cali0707 commented Apr 4, 2024

Also @pierDipi - regarding out discussion about how to set the scale on the trigger manually, what about: if the autoscaling class is set to disabled, then we will use the AutoscalingMinScale annotation?

Copy link
Contributor

github-actions bot commented Jul 4, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

1 participant