Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waits for service endpoints propagation on shutdown in Receiver #1684

Open
pierDipi opened this issue Jan 4, 2022 · 3 comments · May be fixed by #3896
Open

Waits for service endpoints propagation on shutdown in Receiver #1684

pierDipi opened this issue Jan 4, 2022 · 3 comments · May be fixed by #3896
Assignees
@Cali0707
Labels
area/broker Kafka Broker related issues area/channel Kafka Channel related issues area/data-plane area/sink KafkaSink related issues kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@pierDipi
Copy link
Member

pierDipi commented Jan 4, 2022

Problem

The receiver shuts down immediately upon receiving a sigterm and since we
close the HTTP server immediately and the endpoints of the service isn't
yet fully propagated in the cluster there might be requests dropped.

To make the receiver more resilient we need to wait x seconds before
shutting down the server and in the deployment configuration
we need to specify a terminationGracePeriodSeconds > x.

Persona:
Which persona is this feature for?
Event Producer

Time Estimate (optional):
How many developer-days do you think this may take to resolve?
1

Additional context (optional)

/area data-plane
/area broker
/area channel
/area sink
@knative-prow-robot knative-prow-robot added area/broker Kafka Broker related issues area/channel Kafka Channel related issues area/sink KafkaSink related issues labels Jan 4, 2022
@pierDipi pierDipi self-assigned this Jan 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 5, 2022
@pierDipi
Copy link
Member Author

pierDipi commented Apr 5, 2022

/remove-lifecycle stale
/triage accepted

@knative-prow knative-prow bot added triage/accepted Issues which should be fixed (post-triage) and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 5, 2022
@pierDipi pierDipi removed their assignment Apr 8, 2022
@Cali0707
Copy link
Member

/assign

@Cali0707 Cali0707 linked a pull request May 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cali0707 Cali0707

Labels
area/broker Kafka Broker related issues area/channel Kafka Channel related issues area/data-plane area/sink KafkaSink related issues kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: receiver verticle now has a grace period before closing Cali0707/eventing-kafka-broker
3 participants
@pierDipi @knative-prow-robot @Cali0707