Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger's sink takes longer than X to respond (are there any timeouts on the dispatcher acting as a client? Lets ensure there is a defined timeout rather than no timeout - Reference) #671

Closed
Tracked by #592
salaboy opened this issue Mar 31, 2022 · 1 comment · Fixed by #687
Assignees
Projects
Milestone

Comments

@salaboy
Copy link

salaboy commented Mar 31, 2022

The current behaviour is using the ceClient to send a POST HTTP request, and using net/http Client which doesn't define any timeout to start with.

Some reference on how this can be set up: https://blog.cloudflare.com/the-complete-guide-to-golang-net-http-timeouts/
Old references: https://medium.com/@nate510/don-t-use-go-s-default-http-client-4804cb19f779

In my opinion, we should have a configuration to define this timeout on the client inside the dispatcher.

@gab-satchi
Copy link
Contributor

/assign

@xtreme-sameer-vohra xtreme-sameer-vohra added this to the MVP milestone Apr 12, 2022
@xtreme-sameer-vohra xtreme-sameer-vohra added this to TODO in RabbitMQ Apr 12, 2022
@gab-satchi gab-satchi moved this from TODO to In Progress in RabbitMQ Apr 13, 2022
RabbitMQ automation moved this from In Progress to Done Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
RabbitMQ
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants