New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployments resources #771
Deployments resources #771
Conversation
…in the source, broker and trigger reconciler resources specification
/retest |
Codecov Report
@@ Coverage Diff @@
## main #771 +/- ##
==========================================
- Coverage 75.20% 72.86% -2.35%
==========================================
Files 36 36
Lines 2654 2690 +36
==========================================
- Hits 1996 1960 -36
- Misses 588 667 +79
+ Partials 70 63 -7
Continue to review full report at Codecov.
|
fixed receive adapter resources in unit tests
bumped makefile versions updated eventing, ko and kind versions in workflows files reduced resources requests for conformance tests to pass
6d30a9e
to
edad681
Compare
0643af3
to
14bd2bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked into the failures carefully but both the conformance test runs timed out after an hour. That may be an indicator that the settings are too aggressively low.
@@ -24,7 +24,7 @@ jobs: | |||
|
|||
# Map between K8s and KinD versions. | |||
# This is attempting to make it a bit clearer what's being tested. | |||
# See: https://github.com/kubernetes-sigs/kind/releases/tag/v0.11.1 | |||
# See: https://github.com/kubernetes-sigs/kind/releases/tag/v0.12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably update the knative version used for conformance tests. I see e2e is getting updated, conformance tests likely still using 1.1.0 (from Makefile)
I think is the other case, cause with one extra kind node the tests run. So maybe i should set even lower the requests |
393d8f8
to
f3f9a66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gab-satchi, gabo1208 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Both are based on an overall stimation with a scenario where 1500msgs/s are sent over a parallelism of 1000
/kind enhancement
Fixes #703
Release Note