Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployments resources #771

Merged
merged 8 commits into from May 18, 2022

Conversation

gabo1208
Copy link
Contributor

Changes

  • 🎁 Now the Broker's Ingress and Dispatcher have deployment resource requests and limits
  • 🎁 Now the Source's Receive Adapter have deployment resources requests and limits
    Both are based on an overall stimation with a scenario where 1500msgs/s are sent over a parallelism of 1000

/kind enhancement

Fixes #703

Release Note

- 🎁 Now the Broker's Ingress and Dispatcher have deployment resource requests and limits
- 🎁 Now the Source's Receive Adapter have deployment resources requests and limits

…in the source, broker and trigger reconciler resources specification
@knative-prow knative-prow bot added kind/enhancement size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 17, 2022
@gab-satchi
Copy link
Contributor

/retest

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #771 (d553058) into main (275b99c) will decrease coverage by 2.34%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #771      +/-   ##
==========================================
- Coverage   75.20%   72.86%   -2.35%     
==========================================
  Files          36       36              
  Lines        2654     2690      +36     
==========================================
- Hits         1996     1960      -36     
- Misses        588      667      +79     
+ Partials       70       63       -7     
Impacted Files Coverage Δ
pkg/reconciler/broker/resources/dispatcher.go 90.74% <100.00%> (+0.94%) ⬆️
pkg/reconciler/broker/resources/ingress.go 97.36% <100.00%> (+0.25%) ⬆️
pkg/reconciler/source/resources/receive_adapter.go 96.34% <100.00%> (+0.23%) ⬆️
pkg/reconciler/trigger/resources/dispatcher.go 92.24% <100.00%> (+0.65%) ⬆️
pkg/dispatcher/dispatcher.go 11.29% <0.00%> (-59.58%) ⬇️
pkg/apis/eventing/v1/broker_validation.go 83.11% <0.00%> (-0.22%) ⬇️
pkg/adapter/message.go
pkg/rabbit/message.go 71.42% <0.00%> (ø)
pkg/adapter/adapter.go 60.84% <0.00%> (+2.34%) ⬆️
pkg/reconciler/broker/broker_config.go 91.66% <0.00%> (+17.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 275b99c...d553058. Read the comment docs.

fixed receive adapter resources in unit tests
bumped makefile versions

updated eventing, ko and kind versions in workflows files

reduced resources requests for conformance tests to pass
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 18, 2022
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 18, 2022
Copy link
Contributor

@gab-satchi gab-satchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked into the failures carefully but both the conformance test runs timed out after an hour. That may be an indicator that the settings are too aggressively low.

@@ -24,7 +24,7 @@ jobs:

# Map between K8s and KinD versions.
# This is attempting to make it a bit clearer what's being tested.
# See: https://github.com/kubernetes-sigs/kind/releases/tag/v0.11.1
# See: https://github.com/kubernetes-sigs/kind/releases/tag/v0.12.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably update the knative version used for conformance tests. I see e2e is getting updated, conformance tests likely still using 1.1.0 (from Makefile)

@gabo1208
Copy link
Contributor Author

I haven't looked into the failures carefully but both the conformance test runs timed out after an hour. That may be an indicator that the settings are too aggressively low.

I think is the other case, cause with one extra kind node the tests run. So maybe i should set even lower the requests

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 18, 2022
Copy link
Contributor

@gab-satchi gab-satchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2022
@knative-prow
Copy link

knative-prow bot commented May 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gab-satchi, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gab-satchi,gabo1208]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit d50442a into knative-extensions:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add resource.[requests|limits] to reconciled objects
2 participants