Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes secret type for brokerConfig #773

Merged

Conversation

gab-satchi
Copy link
Contributor

  • 🗑️ Secret kind removed as a valid Broker config. Only RabbitmqCluster is supported

/kind removal

Release Note

- With the removal of standalone-broker, Secret type is no longer a supported Broker.Config

@knative-prow knative-prow bot added kind/removal Categorizes issue or PR as related to removing dead code, or deprecated apis/features. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 17, 2022
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #773 (8199576) into main (41df0b6) will increase coverage by 0.49%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #773      +/-   ##
==========================================
+ Coverage   74.84%   75.33%   +0.49%     
==========================================
  Files          35       35              
  Lines        2544     2526      -18     
==========================================
- Hits         1904     1903       -1     
+ Misses        576      559      -17     
  Partials       64       64              
Impacted Files Coverage Δ
pkg/apis/eventing/v1/broker_validation.go 83.11% <100.00%> (-0.22%) ⬇️
pkg/reconciler/broker/broker_config.go 91.66% <100.00%> (+17.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41df0b6...8199576. Read the comment docs.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2022
@knative-prow
Copy link

knative-prow bot commented May 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gab-satchi, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gab-satchi,gabo1208]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit a2b8790 into knative-extensions:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/removal Categorizes issue or PR as related to removing dead code, or deprecated apis/features. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants