Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Move to 1.8.0 #399

Merged
merged 4 commits into from May 12, 2022
Merged

Move to 1.8.0 #399

merged 4 commits into from May 12, 2022

Conversation

skonto
Copy link
Contributor

@skonto skonto commented May 12, 2022

Changes

  • Moves the repo to cert-manager 1.8.0. Intention is to add support for secret template for work in Add filtering support for secret informer in ingress controller net-istio#920 and auto-tls integration.
  • 1.8.0 brings changes to imported packages jetstack is renamed to cert-manager. Might be smoother to get 1.7.0 first but trying the long shot and see.
  • Split in 4 commits for smoother review.

Release Note

cert-manager is now in version 1.8.0.

@knative-prow
Copy link

knative-prow bot commented May 12, 2022

@skonto: The label(s) kind/ cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind enhancement

Release Note

cert-manager is now in version 1.8.0.

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added kind/enhancement size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #399 (240571d) into main (0f9928e) will decrease coverage by 13.53%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #399       +/-   ##
===========================================
- Coverage   90.60%   77.06%   -13.54%     
===========================================
  Files           5        5               
  Lines         266      266               
===========================================
- Hits          241      205       -36     
- Misses         14       50       +36     
  Partials       11       11               
Impacted Files Coverage Δ
pkg/reconciler/certificate/certificate.go 83.09% <ø> (ø)
pkg/reconciler/certificate/config/cert_manager.go 0.00% <ø> (-100.00%) ⬇️
.../certificate/resources/cert_manager_certificate.go 96.29% <ø> (ø)
pkg/reconciler/certificate/config/store.go 0.00% <0.00%> (-100.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f9928e...240571d. Read the comment docs.

@skonto
Copy link
Contributor Author

skonto commented May 12, 2022

/cc @carlisia @ZhiminXiang

Copy link

@ZhiminXiang ZhiminXiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2022
@knative-prow
Copy link

knative-prow bot commented May 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto, ZhiminXiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2022
@knative-prow knative-prow bot merged commit 0cd6d51 into knative-extensions:main May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants