Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TestHTTPOption for gateway-api #130

Open
nak3 opened this issue Sep 7, 2021 · 3 comments · May be fixed by #437
Open

Add TestHTTPOption for gateway-api #130

nak3 opened this issue Sep 7, 2021 · 3 comments · May be fixed by #437
Labels
kind/feature-request lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. upstream/gateway
Milestone

Comments

@nak3
Copy link
Contributor

nak3 commented Sep 7, 2021

knative networking repo added a new test as knative/networking#415.

And 0.4.0-rc1 should support this filter kubernetes-sigs/gateway-api@e4536a0

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 20, 2022
@nak3 nak3 added this to the v1.4.0 milestone Feb 21, 2022
@nak3 nak3 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 21, 2022
@nak3 nak3 modified the milestones: v1.4.0, Icebox Jun 10, 2022
@ReToCode ReToCode linked a pull request Jan 18, 2023 that will close this issue
@ReToCode
Copy link
Member

To summarise, this issue could be done with the current gateway-api spec, but it is a bit verbose (see the PR: #437).
So before we merge it, we are waiting to see what kubernetes-sigs/gateway-api#1185 will bring for version 0.7.0 of the spec (#437 (comment)).

@dprotaso
Copy link
Contributor

Just an FYI - I tried to see if there was interest in simplifying this upstream.

I didn't get the votes kubernetes-sigs/gateway-api#3103 (comment) so it's not going to be in 1.2 (Sept). So the earliest it could land now if it was part of 1.3 would be next year.

I'm thinking we go ahead with the verbose approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. upstream/gateway
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants