Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the gateway reconciler to key off of status conditions. #425

Closed
dprotaso opened this issue Dec 7, 2022 · 3 comments
Closed

Update the gateway reconciler to key off of status conditions. #425

dprotaso opened this issue Dec 7, 2022 · 3 comments
Labels
triage/accepted Issues which should be fixed (post-triage) upstream/gateway

Comments

@dprotaso
Copy link
Contributor

dprotaso commented Dec 7, 2022

As part of gateway release 0.6.0 we have status conditions we can probably key off of for readiness before we mark the KIngress as Ready.

One blocker is that there's no conformance test that the status conditions observeredGeneration is bumped.

Upstream issue: kubernetes-sigs/gateway-api#1584
@dprotaso dprotaso mentioned this issue Feb 7, 2023
Closed
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 24, 2023
@ReToCode
Copy link
Member

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 24, 2023
@ReToCode ReToCode added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. triage/accepted Issues which should be fixed (post-triage) and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 24, 2023
@dprotaso
Copy link
Contributor Author

dprotaso commented Mar 1, 2024

This is done HTTPRoute, Gateway and GatewayClass all have tests asserting generation bumps

@dprotaso dprotaso closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage/accepted Issues which should be fixed (post-triage) upstream/gateway
Projects
No open projects
Gateway API Roadmap
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dprotaso @ReToCode