Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all Gateways have a local K8s Service #665

Closed
dprotaso opened this issue Apr 5, 2024 · 2 comments · Fixed by #685 or #703
Closed

Not all Gateways have a local K8s Service #665

dprotaso opened this issue Apr 5, 2024 · 2 comments · Fixed by #685 or #703
Assignees
@KauzClay
Milestone
v1.14.0

Comments

@dprotaso
Copy link
Contributor

dprotaso commented Apr 5, 2024

Our current gateway config assumes Gateways are running on cluster and have a K8s Service.

net-gateway-api/config/config-gateway.yaml

Line 49 in f925238

service: istio-system/istio-ingressgateway

There are Gateways that are off cluster (eg. LB) - we should support those.

For probing I think the best thing we can do is to probe the IP that appears in the GatewayStatus.Addresses
@dprotaso dprotaso added this to the v1.14.0 milestone Apr 5, 2024
@dprotaso
Copy link
Contributor Author

Note: If we set the IP address in KIngress Status then serving will use it properly

knative/serving#11843

@KauzClay
Copy link
Contributor

/assign

This was referenced Apr 15, 2024
Open
Merged
@KauzClay KauzClay mentioned this issue Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KauzClay KauzClay

Labels
None yet
Projects
None yet
Milestone
v1.14.0
2 participants
@dprotaso @KauzClay