Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create net-istio specific webhook #18

Closed
mattmoor opened this issue Feb 26, 2020 · 3 comments · Fixed by #4
Closed

Create net-istio specific webhook #18

mattmoor opened this issue Feb 26, 2020 · 3 comments · Fixed by #4
Assignees
@trshafer

Comments

@mattmoor
Copy link
Contributor

We should use this for config-istio validation, and some of the new stuff Thomas has planned around canonical service labels.
@dprotaso
Copy link
Contributor

dprotaso commented Mar 5, 2020

Should this move to knative/net-istio repo now?

cc @trshafer

@mattmoor
Copy link
Contributor Author

mattmoor commented Mar 5, 2020

Yeah, I mentioned this somewhere, but i'll transfer the issue.

@mattmoor mattmoor transferred this issue from knative/serving Mar 5, 2020
@tcnghia
Copy link
Contributor

tcnghia commented Mar 5, 2020

/assign @trshafer

@trshafer trshafer mentioned this issue Mar 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trshafer trshafer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add istio defaulting webhook trshafer/net-istio
4 participants
@dprotaso @trshafer @tcnghia @mattmoor