Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local-gateway.mesh: "mesh" option #915

Merged
merged 1 commit into from May 2, 2022

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented May 2, 2022

As per knative/serving#11523, this patch removes local-gateway.mesh: "mesh".

Please note that it does not remove local-gateway.<GATEWAY>: <GATEWAY_SVC> is still availble.
This patch removes only mesh which is a special configuration.

Release Note

`local-gateway.mesh: "mesh"` option was dropped.

/cc @ZhiminXiang @carlisia

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 2, 2022
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #915 (d223205) into main (3295aa6) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head d223205 differs from pull request most recent head cfa4a7d. Consider uploading reports for the commit cfa4a7d to get more accurate results

@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
- Coverage   80.95%   80.85%   -0.11%     
==========================================
  Files          18       18              
  Lines        1607     1598       -9     
==========================================
- Hits         1301     1292       -9     
  Misses        223      223              
  Partials       83       83              
Impacted Files Coverage Δ
pkg/reconciler/ingress/config/istio.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3295aa6...cfa4a7d. Read the comment docs.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 2, 2022
@carlisia
Copy link
Member

carlisia commented May 2, 2022

/retest

@carlisia
Copy link
Member

carlisia commented May 2, 2022

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2022
@knative-prow
Copy link

knative-prow bot commented May 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlisia, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants