Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use paketo builders for all runtimes #1001

Merged
merged 1 commit into from
May 6, 2022

Conversation

lance
Copy link
Member

@lance lance commented Apr 29, 2022

  • 馃Ч Use paketo for all builders

All runtimes were actually using paketo builders already, but the builders were still being explicitly set in manifest.yaml instead of existing as a default in builder.go like all of the others.

Signed-off-by: Lance Ball lball@redhat.com

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 29, 2022
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2022
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #1001 (a739f94) into main (a694cf5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1001   +/-   ##
=======================================
  Coverage   46.71%   46.71%           
=======================================
  Files          57       57           
  Lines        7505     7505           
=======================================
  Hits         3506     3506           
  Misses       3669     3669           
  Partials      330      330           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a694cf5...a739f94. Read the comment docs.

@matejvasek
Copy link
Contributor

@lance you need to regenerate zz_* file since there was another change to spring boot templates.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2022
All runtimes were actually using paketo builders already, but the
builders were still being explicitly set in manifest.yaml instead of
existing as a default in builder.go like all of the others.

Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2022
@lkingland
Copy link
Member

lkingland commented May 6, 2022

Thanks @lance, I was making this change one-language-at-a-time as I added the defaults to S2I; but there's no harm in taking care of them all at once!
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2022
@knative-prow knative-prow bot merged commit 31c1d66 into knative:main May 6, 2022
@lance
Copy link
Member Author

lance commented May 6, 2022

Thanks @lance, I was making this change one-language-at-a-time as I added the defaults to S2I; but there's no harm in taking care of them all at once! /lgtm

Yes, but...

#1005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants