-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use paketo builders for all runtimes #1001
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #1001 +/- ##
=======================================
Coverage 46.71% 46.71%
=======================================
Files 57 57
Lines 7505 7505
=======================================
Hits 3506 3506
Misses 3669 3669
Partials 330 330 Continue to review full report at Codecov.
|
@lance you need to regenerate zz_* file since there was another change to spring boot templates. |
All runtimes were actually using paketo builders already, but the builders were still being explicitly set in manifest.yaml instead of existing as a default in builder.go like all of the others. Signed-off-by: Lance Ball <lball@redhat.com>
Thanks @lance, I was making this change one-language-at-a-time as I added the defaults to S2I; but there's no harm in taking care of them all at once! |
All runtimes were actually using paketo builders already, but the builders were still being explicitly set in manifest.yaml instead of existing as a default in builder.go like all of the others.
Signed-off-by: Lance Ball lball@redhat.com