-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore node_modules for s2i builds #1019
fix: ignore node_modules for s2i builds #1019
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #1019 +/- ##
==========================================
- Coverage 46.41% 46.37% -0.05%
==========================================
Files 58 58
Lines 7568 7575 +7
==========================================
Hits 3513 3513
- Misses 3723 3730 +7
Partials 332 332
Continue to review full report at Codecov.
|
8e59f91
to
b52c8f9
Compare
/lgtm |
I am afraid this won't merege because of the |
Exclude various files and cache directories from S2I builds. This list may need to be expanded in the future.
/kind bug
Fixes #1018