Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore node_modules for s2i builds #1019

Merged

Conversation

lkingland
Copy link
Member

@lkingland lkingland commented May 16, 2022

  • 🎁 Exclude certain directories form S2I build tar know to be either unnecessary or error-prone
  • 🐛 Error running Node Functions which unecessarily had node_modules sent to the build daemon

Exclude various files and cache directories from S2I builds. This list may need to be expanded in the future.

/kind bug

Fixes #1018

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label May 16, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 16, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: lkingland / name: Luke Kingland (8e59f91)

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 16, 2022
@knative-prow
Copy link

knative-prow bot commented May 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2022
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1019 (b52c8f9) into main (ccfa02a) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1019      +/-   ##
==========================================
- Coverage   46.41%   46.37%   -0.05%     
==========================================
  Files          58       58              
  Lines        7568     7575       +7     
==========================================
  Hits         3513     3513              
- Misses       3723     3730       +7     
  Partials      332      332              
Impacted Files Coverage Δ
s2i/builder.go 23.61% <0.00%> (-2.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccfa02a...b52c8f9. Read the comment docs.

@lkingland lkingland force-pushed the lkingland/s2i-exclude-node-modules branch from 8e59f91 to b52c8f9 Compare May 16, 2022 03:55
@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2022
@matejvasek
Copy link
Contributor

I am afraid this won't merege because of the cla/google.

@lkingland lkingland assigned lkingland and unassigned matejvasek May 17, 2022
@lkingland lkingland merged commit 1d367c6 into knative:main May 26, 2022
@lkingland lkingland deleted the lkingland/s2i-exclude-node-modules branch September 20, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S2I Node build fails when using dependencies
2 participants