-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: invoke verbose metadata #944
feat: invoke verbose metadata #944
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
32b42d6
to
d467dd2
Compare
d467dd2
to
d4f18c6
Compare
Codecov Report
@@ Coverage Diff @@
## main #944 +/- ##
==========================================
+ Coverage 43.85% 45.83% +1.98%
==========================================
Files 55 57 +2
Lines 5163 7442 +2279
==========================================
+ Hits 2264 3411 +1147
- Misses 2576 3703 +1127
- Partials 323 328 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great, but I recommend some changes to the output for event invocation, and I've made a small suggestion for the output formatting.
275a73e
to
5a5804b
Compare
5a5804b
to
420ed98
Compare
/lgtm |
Changes
invoke -v
prints metadataHTTP headers or CloudEvent fields are printed on invoke with verbose enabled.
/kind enhancement
Fixes #922