Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add release process and func_darwin_arm64 to the release artifacts #945

Merged
merged 3 commits into from
Apr 7, 2022
Merged

chore: add release process and func_darwin_arm64 to the release artifacts #945

merged 3 commits into from
Apr 7, 2022

Conversation

lance
Copy link
Member

@lance lance commented Apr 6, 2022 •
edited

Changes

  • 馃Ч add func_darwin_arm64 to release artifacts

The MacOS M1 binary was omitted from the release artifacts when added in #932

ADDENDUM:

I noticed in the most recent release, that a MacOS M1 binary was not produced. This commit adds that target to hack/release.sh. Additionally the CHANGELOG.md files and version.txt files have been updated to accurately
reflect the current status. Finally, I've proposed a release process in the new file docs/RELEASING.md.

/kind chore

@lance
fix: add func_darwin_arm64 to the release artifacts
db65653 
Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow knative-prow bot added kind/chore size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 6, 2022
@matejvasek
Copy link
Contributor

/lgtm
/hold for CI

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2022
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2022
@codecov
Copy link

codecov bot commented Apr 6, 2022 •
edited

Codecov Report

Merging #945 (63e3453) into main (739cded) will increase coverage by 1.98%.
The diff coverage is 27.55%.

@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
+ Coverage   43.85%   45.83%   +1.98%     
==========================================
  Files          55       57       +2     
  Lines        5163     7442    +2279     
==========================================
+ Hits         2264     3411    +1147     
- Misses       2576     3703    +1127     
- Partials      323      328       +5
Impacted Files Coverage 螖
client.go 61.94% <0.00%> (+2.01%) 猬嗭笍
cmd/completion_util.go 0.00% <0.00%> (酶)
docker/docker_client.go 82.52% <酶> (+0.57%) 猬嗭笍
k8s/logs.go 0.00% <0.00%> (酶)
k8s/secrets.go 13.54% <0.00%> (-0.75%) 猬囷笍
s2i/builder.go 32.69% <32.69%> (酶)
cmd/build.go 60.49% <70.83%> (+0.86%) 猬嗭笍
cmd/root.go 72.28% <100.00%> (+1.66%) 猬嗭笍
cmd/list.go 56.25% <0.00%> (-3.40%) 猬囷笍
cmd/info.go 24.77% <0.00%> (-2.38%) 猬囷笍
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 36cfef7...63e3453. Read the comment docs.

@lance
chore: add ARM64 release target/propose process
7ae888a 
I noticed in the most recent release, that a MacOS M1 binary was not
produced. This commit adds that target to `hack/release.sh`. Additionally
the CHANGELOG.md files and version.txt files have been updated to accurately
reflect the current status. Finally, I've proposed a release process in
the new file `docs/RELEASING.md`.

Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 6, 2022
@matejvasek
Copy link
Contributor

Merging #945 (db65653) into main (739cded) will increase coverage by 1.98%.

How is this increasing coverage?

@lance
Copy link
Member Author

lance commented Apr 6, 2022

Merging #945 (db65653) into main (739cded) will increase coverage by 1.98%.

How is this increasing coverage?

LOL I have no idea

@lance lance changed the title chore: add func_darwin_arm64 to the release artifacts chore: add release process and func_darwin_arm64 to the release artifacts Apr 6, 2022
@lance
Copy link
Member Author

lance commented Apr 6, 2022

@matejvasek I added some verbiage around the release process as a whole and the lgtm label was removed. Could you ptal?

@matejvasek
Copy link
Contributor

Please fix the Code Style error first.

@lance
fixup: remove trailing whitespace
63e3453 
Signed-off-by: Lance Ball <lball@redhat.com>
zroubalik
zroubalik approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow
Copy link

knative-prow bot commented Apr 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2022
@lance
Copy link
Member Author

lance commented Apr 7, 2022

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2022
@knative-prow knative-prow bot merged commit 4e369a0 into knative:main Apr 7, 2022
@lance
Copy link
Member Author

lance commented Apr 11, 2022

/cherry-pick release-0.23

@knative-prow-robot knative-prow-robot mentioned this pull request Apr 11, 2022
Merged
@knative-prow-robot
Copy link

@lance: new pull request created: #958

In response to this:

/cherry-pick release-0.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@matejvasek matejvasek Awaiting requested review from matejvasek

@salaboy salaboy Awaiting requested review from salaboy

@lkingland lkingland Awaiting requested review from lkingland

Assignees

@zroubalik zroubalik

@matejvasek matejvasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/chore lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lance @matejvasek @knative-prow-robot @zroubalik