Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decompose complicated go-style reusable into composite actions #104

Open
krsna-m opened this issue Mar 16, 2023 · 1 comment
Open

Decompose complicated go-style reusable into composite actions #104

krsna-m opened this issue Mar 16, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@krsna-m
Copy link
Contributor

krsna-m commented Mar 16, 2023

See this todo:

actions/.github/workflows/reusable-style.yaml

Lines 71 to 72 in 19bb67f

# TODO: This should be broken down into composites like the rest
uses: knative/actions/.github/workflows/reusable-helper-go-style.yaml@main

We currently have a [reusable-helper-go-style.yaml](https://github.com/knative/actions/blob/main/.github/workflows/reusable-helper-go-style.yaml) that should really be decomposed down in to composite actions. An example gofmt one already exists here.

While doing this, one could take a look at #65 and see what things we can improve on.
@krsna-m krsna-m added the good first issue Good for newcomers label Mar 16, 2023
@nitishchauhan0022
Copy link
Contributor

/assign

@krsna-m krsna-m mentioned this issue May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nitishchauhan0022 @krsna-m