Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Now tracing works with some eventing sources too #2459

Closed
slinkydeveloper opened this issue May 13, 2020 · 2 comments
Closed

Now tracing works with some eventing sources too #2459

slinkydeveloper opened this issue May 13, 2020 · 2 comments
Assignees
@slinkydeveloper

Comments

@slinkydeveloper
Copy link
Contributor

slinkydeveloper commented May 13, 2020 •
edited

What is changing? (Please include as many details as possible.)

Now the config-tracing map is used by some sources too. This page needs to be updated: https://knative.dev/docs/eventing/accessing-traces/

How will this impact our users?

Users can access to traces from eventing sources

In what release will this take happen (to the best of your knowledge)?

v0.15

Context

Link to associated PRs or issues from other repos here.

  1. Configuration for tracing in sources eventing#3026
  2. Enabled tracing/logging/metrics in gitlab source eventing-contrib#1215
  3. Kafka source tracing eventing-contrib#1211
  4. Prometheus source now supports logging/metrics/tracing CMs eventing-contrib#1240
@slinkydeveloper
Copy link
Contributor Author

/assign

@slinkydeveloper slinkydeveloper mentioned this issue May 25, 2020
Merged
@slinkydeveloper
Copy link
Contributor Author

I think we can close it because we added tracing to all components were this change is doable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slinkydeveloper slinkydeveloper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slinkydeveloper