Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing serviceAccountName definition #438

Closed
l2fprod opened this issue Oct 4, 2018 · 1 comment · Fixed by #510
Closed

Missing serviceAccountName definition #438

l2fprod opened this issue Oct 4, 2018 · 1 comment · Fixed by #510
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Comments

@l2fprod
Copy link

l2fprod commented Oct 4, 2018

serviceAccountName: build-bot is missing from the build section:

docs/serving/samples/source-to-url-go/service.yaml

Line 9 in 6d21cd8

build:

The README.md has it correct
@RichieEscarez RichieEscarez mentioned this issue Nov 6, 2018
Merged
@RichieEscarez RichieEscarez added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/enhancement labels Nov 6, 2018
@RichieEscarez
Copy link
Contributor

fixed in #524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sync README.md and service.yaml RichieEscarez/docs
2 participants
@RichieEscarez @l2fprod