Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hard code builder image locations #120

Closed
lance opened this issue Sep 14, 2020 · 2 comments · Fixed by #136
Closed

Do not hard code builder image locations #120

lance opened this issue Sep 14, 2020 · 2 comments · Fixed by #136
Assignees

Comments

@lance
Copy link
Member

lance commented Sep 14, 2020

The buildpack Runtimes are all currently hard coded.

https://github.com/boson-project/faas/blob/566d8f9255d532e88e72d5bce122bebaee88bc81/buildpacks/builder.go#L25-L29

It would be nice for this to be configurable.

@lance
Copy link
Member Author

lance commented Sep 14, 2020

As I think more about this issue, it's making me realize that all of the actions this CLI takes are really not function-specific. Making the runtime buildpacks configurable would mean that this CLI could extend the same build/deploy/update/delete workflow to essentially anything that could be deployed as a Knative service and which has a buildpack. Want to run a Django app on Knative? Point faas at https://github.com/cloudfoundry/python-buildpack and it's easy.

@boson-project/core wdyt?

@lance
Copy link
Member Author

lance commented Sep 18, 2020

What if, instead of configuring builders explicitly, we simply add metadata to the templates. For example:

cat templates/node/http/.builder     147ms  Fri 18 Sep 2020 03:49:45 PM EDT
───────┬──────────────────────────────────────────────────────────────────────
       │ File: templates/node/http/.builder
───────┼──────────────────────────────────────────────────────────────────────
   1   │ quay.io/boson/faas-nodejs-builder
───────┴──────────────────────────────────────────────────────────────────────

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant